Browse Source

Implement Review comments

CURA-5479
Nino van Hooff 4 years ago
parent
commit
06284b6a73

+ 1 - 2
cura/UI/PrintInformation.py

@@ -254,8 +254,7 @@ class PrintInformation(QObject):
     def _onPreferencesChanged(self, preference: str) -> None:
         if preference == "cura/job_name_template":
             self._updateJobName()
-
-        if preference == "cura/material_settings":
+        elif preference == "cura/material_settings":
             for build_plate_number in range(self._multi_build_plate_model.maxBuildPlate + 1):
                 self._calculateInformation(build_plate_number)
 

+ 3 - 3
resources/qml/Preferences/GeneralPage.qml

@@ -642,7 +642,7 @@ UM.PreferencesPage
                     TextField
                     {
                         id: jobNameTemplateTextField
-                        width: 200 * screenScaleFactor
+                        width: 250 * screenScaleFactor
                         text: UM.Preferences.getValue("cura/job_name_template")
                         onTextChanged: UM.Preferences.setValue("cura/job_name_template", text)
                     }
@@ -681,7 +681,7 @@ UM.PreferencesPage
                     ComboBox
                     {
                         id: choiceOnOpenProjectDropDownButton
-                        width: 200 * screenScaleFactor
+                        width: 250 * screenScaleFactor
 
                         model: ListModel
                         {
@@ -747,7 +747,7 @@ UM.PreferencesPage
                     ComboBox
                     {
                         id: choiceOnProfileOverrideDropDownButton
-                        width: 200 * screenScaleFactor
+                        width: 250 * screenScaleFactor
 
                         model: ListModel
                         {

+ 1 - 1
tests/TestPrintInformation.py

@@ -26,7 +26,7 @@ def getPrintInformation(printer_name) -> PrintInformation:
     mocked_extruder_stack.material = mocked_material
 
     mock_application.getInstance = MagicMock(return_value = mock_application)
-    mocked_preferences.getValue = MagicMock(side_effect=preferencesGetValue)
+    mocked_preferences.getValue = MagicMock(side_effect = preferencesGetValue)
 
     global_container_stack = MagicMock()
     global_container_stack.definition.getName = MagicMock(return_value = printer_name)